Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Warn user about mismatching image filter annotations #1936

Closed
hiddeco opened this issue Apr 15, 2019 · 1 comment
Closed

Warn user about mismatching image filter annotations #1936

hiddeco opened this issue Apr 15, 2019 · 1 comment
Labels
enhancement UX In pursuit of a delightful user experience

Comments

@hiddeco
Copy link
Member

hiddeco commented Apr 15, 2019

Annotating HelmRelease resources with image filters can be tricky due to the fact that there is a difference between annotating top- and sub-level images (chart-image should be used for the former, <sub-level> should be used for the latter).

We can guide people in this by logging a warning in case we find an annotation that does not match a key from the values in the HelmRelease.

In extend we can also do this for Kubernetes native resources (Deployment, DaemonSet, etc), and warn the user when an annotation does not match any of the (init)Containers names.

@hiddeco hiddeco added UX In pursuit of a delightful user experience enhancement labels Apr 15, 2019
@kingdonb
Copy link
Member

No further enhancements can land in Flux v1,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement UX In pursuit of a delightful user experience
Projects
None yet
Development

No branches or pull requests

2 participants