Rename --registry-poll-interval

[squaremo]

The flag --registry-poll-interval used to control how often fluxd would scan image repos for new images, and consequently update any automated workloads. This has not been true for some time: it now just controls the second part, while images are scanned on a different schedule. The name is a persistent source of confusion.

Therefore: introduce a new flag --automation-interval, and make --registry-poll-interval a synonym so as not to break things suddenly, and deprecate the latter so as to encourage people to change it.

[MilanDasek]

@squaremo Hello, I would like to ask

I do see a lot of AWS API calls to ECR in CloudTrail form our EKS clusters.

I have these settings in Flux

        - --git-poll-interval=3m
        - --sync-interval=3m
        - --automation-interval=10m
        - --registry-poll-interval=10m

But it seems images are scanned more frequently - every minute (image details redacted)

ts=2020-02-14T09:17:16.836607922Z caller=warming.go:198 component=warmer info="refreshing image" image=.dkr.ecr.us-east-1.amazonaws.com/ tag_count=169 to_update=5 of_which_refresh=5 of_which_missing=0
ts=2020-02-14T09:17:16.981931851Z caller=warming.go:206 component=warmer updated=.dkr.ecr.us-east-1.amazonaws.com/ successful=5 attempted=5
ts=2020-02-14T09:18:10.675799632Z caller=warming.go:198 component=warmer info="refreshing image" image=.dkr.ecr.us-east-1.amazonaws.com/ tag_count=169 to_update=2 of_which_refresh=2 of_which_missing=0
ts=2020-02-14T09:18:10.930028855Z caller=warming.go:206 component=warmer updated=.dkr.ecr.us-east-1.amazonaws.com/ successful=2 attempted=2
ts=2020-02-14T09:19:11.817184708Z caller=warming.go:198 component=warmer info="refreshing image" image=.dkr.ecr.us-east-1.amazonaws.com/ tag_count=169 to_update=2 of_which_refresh=2 of_which_missing=0
ts=2020-02-14T09:19:11.959433455Z caller=warming.go:206 component=warmer updated=.dkr.ecr.us-east-1.amazonaws.com/ successful=2 attempted=2
ts=2020-02-14T09:20:21.046095502Z caller=warming.go:198 component=warmer info="refreshing image" image=.dkr.ecr.us-east-1.amazonaws.com/ tag_count=169 to_update=1 of_which_refresh=1 of_which_missing=0
ts=2020-02-14T09:20:21.166069252Z caller=warming.go:206 component=warmer updated=.dkr.ecr.us-east-1.amazonaws.com/ successful=1 attempted=1
ts=2020-02-14T09:21:11.845695164Z caller=warming.go:198 component=warmer info="refreshing image" image=.dkr.ecr.us-east-1.amazonaws.com/ tag_count=169 to_update=5 of_which_refresh=5 of_which_missing=0
ts=2020-02-14T09:21:12.280640761Z caller=warming.go:206 component=warmer updated=.dkr.ecr.us-east-1.amazonaws.com/ successful=5 attempted=5

Can you please help me understand why is that?

Flux version: image: docker.io/fluxcd/flux:1.14.2

Thank you