Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pkg/runtime helpers #322

Closed
5 tasks
hiddeco opened this issue Oct 1, 2021 · 0 comments · Fixed by #342 or #738
Closed
5 tasks

Implement pkg/runtime helpers #322

hiddeco opened this issue Oct 1, 2021 · 0 comments · Fixed by #342 or #738
Labels
enhancement New feature or request

Comments

@hiddeco
Copy link
Member

hiddeco commented Oct 1, 2021

As part of the refactor work to set out some standards for the controllers that are part of the Flux family, the pkg/runtime helpers and interfaces should be implemented to work with the conditions, metrics and events recorded for HelmRelease resources.

In short, (at least) the following should be implemented:

  • HelmRelease should implement the interfaces from conditions, and use this package to work with conditions.
  • HelmReleaseReconciler should implement the helpers from controller, and use these to record Events and Metrics.
  • HelmReleaseReconciler should exit early without recording any status when .spec.suspend is defined.
  • The patch package should be implemented to (safely) patch resources without running into conflicts.
  • The kstatus Reconciling and Stalled conditions should be properly implemented to provide better signals.

More examples can be found at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant