Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOPS AZKV environment variable configuration doesn't work #839

Closed
apeschel opened this issue Apr 21, 2023 · 2 comments
Closed

SOPS AZKV environment variable configuration doesn't work #839

apeschel opened this issue Apr 21, 2023 · 2 comments

Comments

@apeschel
Copy link
Contributor

apeschel commented Apr 21, 2023

It looks like a mistake was made in the logic, and the environment variable credentials are retrieved, but never used.

I've opened a PR to address this issue.

#838

You can refer to this Slack thread for more details: https://cloud-native.slack.com/archives/CLAJ40HV3/p1682102413111849

The SOPS AZKV tests seem to intend to have coverage for configuring auth via environment variables, but something is amiss because the tests seem to be passing even though the functionality is broken.

https://github.com/fluxcd/kustomize-controller/blob/main/internal/sops/azkv/keysource_integration_test.go

@apeschel
Copy link
Contributor Author

Relates to #841

@kingdonb
Copy link
Member

kingdonb commented May 3, 2023

Closing with #842 (fixed in Flux 2.0.0-rc.2)

@kingdonb kingdonb closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants