Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fluxcd/pkg/runtime to v0.8.0 #247

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Update fluxcd/pkg/runtime to v0.8.0 #247

merged 2 commits into from
Jan 21, 2021

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Jan 21, 2021 •
edited
Loading

Changes:

  • fluxcd/pkg/apis/meta v0.7.0
  • update fluxcd/pkg/runtime to v0.8.0
  • hook Kubernetes client and logger flags from runtime
  • use fluxcd/pkg/meta object ref types

@stefanprodan
Update fluxcd/pkg/runtime to v0.8.0
9a7185e 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added the area/ci CI related issues and pull requests label Jan 21, 2021
hiddeco
hiddeco approved these changes Jan 21, 2021
View reviewed changes
main.go
Comment on lines +81 to +82
clientOptions.BindFlags(flag.CommandLine)
logOptions.BindFlags(flag.CommandLine)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little clean-up 💯

@stefanprodan
Use the object reference type from fluxcd/pkg/meta
62a764a 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan merged commit 360a9ec into main Jan 21, 2021
@stefanprodan stefanprodan deleted the flux-runtime-v0.8.0 branch January 21, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/ci CI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @hiddeco