Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow failed reconciliations to be scheduled at a different interval #250

Merged
merged 4 commits into from
Jan 22, 2021

Conversation

stefanprodan
Copy link
Member

This PR adds an optional field spec.retryInterval to the API that allows users to requeue a failed reconciliation at a different interval than spec.Interval.

Changes:

  • Add RetryInterval as optional field to API. The spec.retryInterval is the interval at which to retry a previously failed reconciliation. When not specified, it defaults to the spec.interval value.
  • Requeue a failed reconciliation based on retry interval
  • Add reconciliation unit test to verify that objects are create in cluster and labeled accordingly

Fix: #246

The spec.retryInterval is the interval at which to retry a previously failed reconciliation.
When not specified, it defaults to the spec.interval value.

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Verify that objects are create in cluster and labeled accordingly

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added area/docs Documentation related issues and pull requests enhancement New feature or request area/kustomize Kustomize related issues and pull requests labels Jan 22, 2021
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan merged commit 89017ca into main Jan 22, 2021
@stefanprodan stefanprodan deleted the retry-interval branch January 22, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests area/kustomize Kustomize related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinct reconciliation interval for failed (previous) reconciliation state
2 participants