sops/keyservice: properly fallback to default #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
bug
hiddeco
force-pushed
the
fix-azkv-fallback
branch
from
770bffe
to
7bfca96
Compare
darkowlzz
approved these changes
Mar 25, 2022
hiddeco
force-pushed
the
fix-azkv-fallback
branch
from
7bfca96
to
2f6c2b7
Compare
This solves a regression bug introduced in `v0.22.0`, which caused the keyservice to not properly fall back to the default for Azure Key Vault decryption requests. A couple of nitpicks that I ran into while inspecting the code have been adressed as well. Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
fix-azkv-fallback
branch
from
cff0c0b
to
dc5486f
Compare
|
Although there is no positive confirmation yet that this solves the issue described in #595, I am going ahead and merge this, as I am confident it addresses at least one variant of the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(AMD64) image for testing available at:
hiddeco/kustomize-controller:fix-azkv-fallback-dc5486fPotentially addresses: #595