Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support alternative kustomization file names #738

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Support alternative kustomization file names #738

merged 1 commit into from
Oct 4, 2022

Conversation

makkes
Copy link
Member

@makkes makkes commented Oct 4, 2022 •
edited
Loading

KustomizeGenerator.WriteFile now detects alternative kustomization
file names such as kustomization.yml and Kustomization.

closes #737

@makkes makkes requested a review from hiddeco October 4, 2022 11:35
@makkes makkes self-assigned this Oct 4, 2022
@makkes makkes added bug Something isn't working area/kustomize Kustomize related issues and pull requests labels Oct 4, 2022
hiddeco
hiddeco reviewed Oct 4, 2022
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but think smashing (especially the last commit) would be better to keep main free from noise.

@makkes
support alternative kustomization file names
c3c4cc1 
`KustomizeGenerator.WriteFile` now detects alternative kustomization
file names such as `kustomization.yml` and `Kustomization`.

closes #737

Signed-off-by: Max Jonas Werner <max@e13.dev>
@makkes
Copy link
Member Author

makkes commented Oct 4, 2022

Changes look good to me, but think smashing (especially the last commit) would be better to keep main free from noise.

Sure thing, was planning to do that, anyway. Just wanted to simplify review. Will squash now.

@makkes makkes force-pushed the alternative-kustomization-files branch from 8c0a7e0 to c3c4cc1 Compare October 4, 2022 13:35
@hiddeco hiddeco changed the title support alternative kustomization file names Support alternative kustomization file names Oct 4, 2022
@makkes makkes merged commit 5c8aa7a into main Oct 4, 2022
@makkes makkes deleted the alternative-kustomization-files branch October 4, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees

@makkes makkes

Labels
area/kustomize Kustomize related issues and pull requests bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kustomization files with name other than the default kustomization.yaml aren't processed properly
2 participants
@makkes @hiddeco