Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom AWS STS endpoint for bucket/S3 source #1423

Closed
Tracked by #4947
bdalpe opened this issue Apr 1, 2024 · 3 comments · Fixed by #1552
Closed
Tracked by #4947

Add support for custom AWS STS endpoint for bucket/S3 source #1423

bdalpe opened this issue Apr 1, 2024 · 3 comments · Fixed by #1552
Assignees
Labels
area/bucket Bucket related issues and pull requests enhancement New feature or request

Comments

@bdalpe
Copy link

bdalpe commented Apr 1, 2024

This would enable usage of MinIO STS auth

@stefanprodan
Copy link
Member

We support OIDC auth for AWS, Azure and GCP, docs here: https://fluxcd.io/flux/components/source/buckets/#provider

Is this feature request for MinIO own implementation?

@scmeli
Copy link

scmeli commented Jul 10, 2024

The MinIO credentials package already supports a custom STS endpoint, so I think the request is to add it to the bucket.Spec and pass to the minio wrapper:

 	} else if bucket.Spec.Provider == sourcev1.AmazonBucketProvider {
-		opt.Creds = credentials.NewIAM("")
+		opt.Creds = credentials.NewIAM(bucket.Spec.STSEndpoint)
 	}

@bdalpe
Copy link
Author

bdalpe commented Jul 16, 2024

@scmeli is correct, this request is to expose the STS endpoint configuration to accept custom values.

This is relevant for MinIO, but also for AWS especially when running in a VPC an interface endpoint for STS or wanting to use the regional STS endpoints.

@stefanprodan stefanprodan added enhancement New feature or request area/bucket Bucket related issues and pull requests labels Jul 16, 2024
@matheuscscp matheuscscp changed the title Add support for custom STS endpoint for bucket/S3 source Add support for custom AWS STS endpoint for bucket/S3 source Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bucket Bucket related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants