-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy support for OCIRepository API #1536
Conversation
33ee8b6
to
2ccda4a
Compare
.spec.proxySecretRef
for OCIRepository APIThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @matheuscscp 🏅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall implementation looks good to me.
Suggested a test with goproxy against the test registry.
1020bbb
to
ddc34c8
Compare
ddc34c8
to
9422053
Compare
75e2c4f
to
1b44a2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the proxy tests in OCI artifact verification. The notation related changes also look nice and minimal.
Left a few suggestions in the tests and docs. Everything else looks good to me.
0f905bb
to
a99476f
Compare
a503050
to
c9b27e1
Compare
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
c9b27e1
to
03a118a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for all the work on it.
Fixes #1492