Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated SHA-1 is used for checksums #467

Closed
dholbach opened this issue Oct 26, 2021 · 3 comments · Fixed by #487
Closed

Deprecated SHA-1 is used for checksums #467

dholbach opened this issue Oct 26, 2021 · 3 comments · Fixed by #487

Comments

@dholbach
Copy link
Member

Found by Ada Logics:

In the storage utility of the source controller checksums on the collected artifacts are calculated using SHA-1. SHA-1 is considered deprecated as collision attacks against SHA-1 are feasible.

Switch from SHA-1 to SHA-2 in checksum calculations.

We want to emphasize here that it is only in the checksum calculation SHA-1 is recommended not to be used. In the HMAC implementation of Flux SHA-1 is still safe to use.
@hiddeco
Copy link
Member

hiddeco commented Oct 26, 2021

Note that this already was changed in e79b573, but may need a backport to land sooner.

@dholbach
Copy link
Member Author

PR in question was #423

@dholbach
Copy link
Member Author

Anyone up for cherry-picking this?

@relu relu mentioned this issue Nov 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

storage: change Artifact checksum to SHA256 fluxcd/source-controller
2 participants
@dholbach @hiddeco