Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ND range change messages are incorrect #9473

Open
Benjozork opened this issue Nov 10, 2024 · 12 comments · May be fixed by #9739
Open

ND range change messages are incorrect #9473

Benjozork opened this issue Nov 10, 2024 · 12 comments · May be fixed by #9739
Labels
A380X Related to the A380X aircraft Bug Something isn't working Good First Issue Good for newcomers

Comments

@Benjozork
Copy link
Member

Aircraft Version

Stable

Build info

N/A

Describe the bug

ND says "RANGE CHANGE"
VD has no message

Expected behavior

ND should say "ND RANGE CHANGE"
VD should say "VD RANGE CHANGE"

Steps to reproduce

  1. Load up aircraft
  2. Change ND range
  3. Observe

References (optional)

No response

Additional info (optional)

No response

Discord Username (optional)

No response

@Benjozork Benjozork added Bug Something isn't working Good First Issue Good for newcomers A380X Related to the A380X aircraft labels Nov 10, 2024
@danestfanous
Copy link
Contributor

I would like to attempt this.

@heclak
Copy link
Contributor

heclak commented Nov 22, 2024

i think i saw someone collecting info on discord to work on this. not sure if they have already completed it. best to check on discord. if no one is working on it, make a draft PR first.

@danestfanous
Copy link
Contributor

Yeah that was me. Sorry for the confusion.

@MrJigs7
Copy link
Contributor

MrJigs7 commented Dec 10, 2024

@danestfanous Hi just wanted to check if you are still working on this? If not I can take a look at it

@danestfanous
Copy link
Contributor

@MrJigs7 Hello! I was able to fix it on my end but I couldn't sync it with Github. Feel free to give it a try and let me know if you'd like to see what I did.

@MrJigs7
Copy link
Contributor

MrJigs7 commented Dec 10, 2024

What’s the issue with the sync?

@MrJigs7
Copy link
Contributor

MrJigs7 commented Dec 10, 2024

@danestfanous Feel free to send over what you did and I can push it and will add you as a credit on the change log 👍

@danestfanous
Copy link
Contributor

My issue was that I was able to make the change with the files on my computer, but when attempting to edit the code on GitHub, I found that the files are in fbw-common so it was a little more complicated.

If you'd like, send me your discord, it would be easier to discuss there.

@MrJigs7
Copy link
Contributor

MrJigs7 commented Dec 10, 2024

Sure, MrJigs on discord

@danestfanous
Copy link
Contributor

I sent you a friend request. I'm sad10mane

@MrJigs7
Copy link
Contributor

MrJigs7 commented Jan 6, 2025

Whilst working on this I've noticed the RANGE CHANGE flag positioning seems a little off, at least compared to the reference picture provided on Discord for the A380. Happy to update it as part of this issue if someone is able to provide a reference picture of the RANGE CHANGE flag on the A320 so I can check if the positioning is the same

@BravoMike99
Copy link
Contributor

Whilst working on this I've noticed the RANGE CHANGE flag positioning seems a little off, at least compared to the reference picture provided on Discord for the A380. Happy to update it as part of this issue if someone is able to provide a reference picture of the RANGE CHANGE flag on the A320 so I can check if the positioning is the same

image

It may just be the "ND" text shifting everything to the right on the A380
image

@MrJigs7 MrJigs7 linked a pull request Jan 9, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft Bug Something isn't working Good First Issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants