From 2bda4006c3f22a9222d0749f8232211dada98aef Mon Sep 17 00:00:00 2001
From: Andrei Solntsev <andrei.solntsev@gmail.com>
Date: Sun, 26 May 2024 21:26:04 +0300
Subject: [PATCH] fix warning "Catch block may ignore exception"

---
 .idea/inspectionProfiles/Project_Default.xml                  | 4 ++++
 flying-saucer-examples/src/main/java/BrowsePanel.java         | 4 ++--
 .../main/java/org/xhtmlrenderer/demo/browser/swt/Browser.java | 2 ++
 .../org/xhtmlrenderer/demo/browser/swt/BrowserUserAgent.java  | 4 ++--
 4 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
index c792d90d1..5fd5fef4c 100644
--- a/.idea/inspectionProfiles/Project_Default.xml
+++ b/.idea/inspectionProfiles/Project_Default.xml
@@ -2,6 +2,10 @@
   <profile version="1.0">
     <option name="myName" value="Project Default" />
     <inspection_tool class="BooleanMethodIsAlwaysInverted" enabled="false" level="WARNING" enabled_by_default="false" />
+    <inspection_tool class="CatchMayIgnoreException" enabled="true" level="WARNING" enabled_by_default="true">
+      <option name="m_ignoreCatchBlocksWithComments" value="false" />
+      <option name="m_ignoreNonEmptyCatchBlock" value="false" />
+    </inspection_tool>
     <inspection_tool class="Convert2MethodRef" enabled="true" level="INFORMATION" enabled_by_default="true" />
     <inspection_tool class="HtmlTagCanBeJavadocTag" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="JavadocBlankLines" enabled="false" level="WARNING" enabled_by_default="false" />
diff --git a/flying-saucer-examples/src/main/java/BrowsePanel.java b/flying-saucer-examples/src/main/java/BrowsePanel.java
index 6077c2108..1cf1e330b 100644
--- a/flying-saucer-examples/src/main/java/BrowsePanel.java
+++ b/flying-saucer-examples/src/main/java/BrowsePanel.java
@@ -47,7 +47,7 @@
  */
 public class BrowsePanel {
     private static final Logger log = LoggerFactory.getLogger(BrowsePanel.class);
-    
+
     private String uri;
     private XHTMLPanel panel;
     private JFrame frame;
@@ -170,7 +170,7 @@ private void loadAndCheckArgs(String[] args) {
             try {
                 new URL(name);
             } catch (MalformedURLException e) {
-                throw new IllegalArgumentException("File " + name + " does not exist or is not a URI");
+                throw new IllegalArgumentException("File " + name + " does not exist or is not a URI", e);
             }
         }
         this.uri = name;
diff --git a/flying-saucer-swt-examples/src/main/java/org/xhtmlrenderer/demo/browser/swt/Browser.java b/flying-saucer-swt-examples/src/main/java/org/xhtmlrenderer/demo/browser/swt/Browser.java
index fcf232562..20c09dfa5 100644
--- a/flying-saucer-swt-examples/src/main/java/org/xhtmlrenderer/demo/browser/swt/Browser.java
+++ b/flying-saucer-swt-examples/src/main/java/org/xhtmlrenderer/demo/browser/swt/Browser.java
@@ -283,12 +283,14 @@ private Image loadImage(@Nullable String icon) {
         try {
             url = new URL(uri);
         } catch (MalformedURLException e) {
+            log.debug("Failed to load image {} from uri {}", icon, uri, e);
             return null;
         }
         InputStream is;
         try {
             is = url.openStream();
         } catch (IOException e) {
+            log.debug("Failed to load image {} from uri {}", icon, uri, e);
             return null;
         }
         if (is == null) {
diff --git a/flying-saucer-swt-examples/src/main/java/org/xhtmlrenderer/demo/browser/swt/BrowserUserAgent.java b/flying-saucer-swt-examples/src/main/java/org/xhtmlrenderer/demo/browser/swt/BrowserUserAgent.java
index f3548dc57..4c65f7fca 100644
--- a/flying-saucer-swt-examples/src/main/java/org/xhtmlrenderer/demo/browser/swt/BrowserUserAgent.java
+++ b/flying-saucer-swt-examples/src/main/java/org/xhtmlrenderer/demo/browser/swt/BrowserUserAgent.java
@@ -96,7 +96,7 @@ public String resolveURI(@Nullable String uri) {
                         ref = new URL(duri);
                     }
                 } catch (MalformedURLException e) {
-                    Uu.p("URI/URL is malformed: " + burl + " or " + uri);
+                    Uu.p("URI/URL is malformed: %s or %s (caused by: %s)".formatted(burl, uri, e));
                 }
             } else {
                 if (!short_url.startsWith("/")) {
@@ -119,7 +119,7 @@ public String resolveURI(@Nullable String uri) {
                 }
                 ref = new URL(base, uri);
             } catch (MalformedURLException e) {
-                Uu.p("URI/URL is malformed: " + burl + " or " + uri);
+                Uu.p("URI/URL is malformed: %s or %s (caused by: %s)".formatted(burl, uri, e));
             }
         }