Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove various old packages and libraries #297

Closed
andreasrosdal opened this issue Mar 19, 2024 · 2 comments
Closed

Remove various old packages and libraries #297

andreasrosdal opened this issue Mar 19, 2024 · 2 comments

Comments

@andreasrosdal
Copy link
Contributor

andreasrosdal commented Mar 19, 2024

I recommend removing these old packages and libraries. By removing flying-saucer-pdf-itext5 and flying-saucer-swt there will be a smaller, more maintainable code-base, which will ease the modernization of this library, eg. support modern HTML 5 etc. Also remove the jar files in lib/dev, these jar files should be included by Maven if they are needed.

https://github.com/flyingsaucerproject/flyingsaucer/tree/main/lib/dev
https://github.com/flyingsaucerproject/flyingsaucer/tree/main/lib

https://github.com/flyingsaucerproject/flyingsaucer/tree/main/flying-saucer-pdf-itext5 (iText 5 is EOL)
https://github.com/flyingsaucerproject/flyingsaucer/tree/main/flying-saucer-swt (SWT is not used much, could be removed or
forked out to a separate project under https://github.com/flyingsaucerproject)
https://github.com/flyingsaucerproject/flyingsaucer/tree/main/flying-saucer-swt-examples

@asolntsev
Copy link
Contributor

Thank you, I was also thinking about it.
Especially, about removing Swing code.

@pbrant What do you think, can we remove "itext5" and "swt" support"?

@pbrant
Copy link
Member

pbrant commented Mar 19, 2024

I'm pretty sure that the JARs under lib are just detritus from the old Ant build. They can definitely go.

Looking at the Maven download stats, both itext5 and swt get considerably more downloads than I would have thought (67k and 1.6k last month respectively). It doesn't seem worth it to spend extra effort keeping them going, but I don't think we need to be in any rush to remove them either.

Basically we need concrete arguments here, e.g. "I have this awesome flex box PR, but that darn SWT support is getting in the way" In that case, it's an easy choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants