Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Configure grpc_health_prob in admin #1698

Closed
2 tasks done
yindia opened this issue Oct 18, 2021 · 1 comment
Closed
2 tasks done

[Housekeeping] Configure grpc_health_prob in admin #1698

yindia opened this issue Oct 18, 2021 · 1 comment
Assignees
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Milestone

Comments

@yindia
Copy link
Contributor

yindia commented Oct 18, 2021

Describe the issue

Currently, flyteadmin doesn't have a health check prob in deployment. We need a health check prob for flyteadmin. We can use https://github.com/grpc-ecosystem/grpc-health-probe for running a health check

What if we do not do this?

It's best practice

Related component(s)

flyteadmin

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@yindia yindia added housekeeping Issues that help maintain flyte and keep it tech-debt free hacktoberfest labels Oct 18, 2021
@EngHabu
Copy link
Contributor

EngHabu commented Feb 18, 2022

  1. We have installed grpc healthcheck in boilerplate Dockerfile template but it hasn't been applied to flyteadmin's Dockerfile.

  2. Docs for gRPC liveness probes: this and this.

  3. We should also add healthchecks for the REST endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

No branches or pull requests

3 participants