Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] With GRPC v1.46.0 non-ascii chars are not permitted in grpc metadata #2444

Closed
2 tasks done
pmahindrakar-oss opened this issue May 4, 2022 · 2 comments · Fixed by flyteorg/flyteadmin#426
Closed
2 tasks done
Assignees
Labels
bug Something isn't working flyteadmin Issue for FlyteAdmin Service
Milestone

Comments

@pmahindrakar-oss
Copy link
Contributor

pmahindrakar-oss commented May 4, 2022

Describe the bug

With this change grpc/grpc-go#468

The data populated in metadata has to be ascii data
https://github.com/flyteorg/flyteadmin/blob/6591fa2a6303ee5dc6f47db9c9725cf72c0db99a/auth/handlers.go#L326

Hence umlaut chars used by the User in there IDP provider would fail in admin and throw

Request failed with status code 500 header key "userinfo" contains value with non-printable ASCII characters

Expected behavior

The request shouldn't fail .

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@pmahindrakar-oss pmahindrakar-oss added bug Something isn't working flyteadmin Issue for FlyteAdmin Service labels May 4, 2022
@pmahindrakar-oss
Copy link
Contributor Author

cc : @katrogan @EngHabu @sbrunk

@pmahindrakar-oss pmahindrakar-oss self-assigned this May 4, 2022
@pmahindrakar-oss pmahindrakar-oss added this to the 1.0.1 milestone May 4, 2022
@bimtauer
Copy link
Contributor

Hi we're using OpenID connect with Google and are having a lot of problems with this since many of our colleagues have non-ascii conforming names 😅 🇫🇮 We solved this now by downgrading flyteadmin, but a quick fix would help us a lot 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyteadmin Issue for FlyteAdmin Service
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants