Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Notifications should be validated in admin #2601

Closed
2 tasks done
katrogan opened this issue Jun 8, 2022 · 0 comments
Closed
2 tasks done

[BUG] Notifications should be validated in admin #2601

katrogan opened this issue Jun 8, 2022 · 0 comments
Assignees
@katrogan
Labels
bug Something isn't working flyteadmin Issue for FlyteAdmin Service good first issue Good for newcomers housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@katrogan
Copy link
Contributor

katrogan commented Jun 8, 2022

Describe the bug

Launch plan request specs and execution spec validation should include verifying notifications are valid.

Expected behavior

Invalid notifications (missing recipient emails, or with non-terminal phases) should not be allowed during registration and create execution request time.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@katrogan katrogan added bug Something isn't working flyteadmin Issue for FlyteAdmin Service labels Jun 8, 2022
@katrogan katrogan self-assigned this Jun 8, 2022
@katrogan katrogan mentioned this issue Jun 8, 2022
Merged
8 tasks
@wild-endeavor wild-endeavor added good first issue Good for newcomers housekeeping Issues that help maintain flyte and keep it tech-debt free labels Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katrogan katrogan

Labels
bug Something isn't working flyteadmin Issue for FlyteAdmin Service good first issue Good for newcomers housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@katrogan @wild-endeavor