Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Consolidate default log formats in flytekit and the backend #3293

Open
2 tasks done
Tracked by #4064
eapolinario opened this issue Jan 28, 2023 · 5 comments
Open
2 tasks done
Tracked by #4064

[BUG] Consolidate default log formats in flytekit and the backend #3293

eapolinario opened this issue Jan 28, 2023 · 5 comments
Labels
bug Something isn't working flytekit FlyteKit Python related issue good first issue Good for newcomers stale

Comments

@eapolinario
Copy link
Contributor

Describe the bug

We currently use 2 slightly different logging formats in flytekit and the backend components.

This forces users to maintain multiple parsers to be able to ingest Flyte logs.

Expected behavior

We need to be backwards compatible, so at the very least we should expose the logging format used by flytekit.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@eapolinario eapolinario added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers flytekit FlyteKit Python related issue good first issue Good for newcomers labels Jan 28, 2023
@andrusha
Copy link

Wouldn't it be better to use Flyte-like logging in Flytekit instead?

It'll be a breaking change for library consumers, but then also Flytekit logging format is a mix of plaintext and json without ability to override it from the Python root logger. This seem to be more problematic to parse than straight json coming from Flyte itself and I would rather standardize on that one.

@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Feb 10, 2023
@eapolinario
Copy link
Contributor Author

@andrusha , the key here is that this would be a breaking change. We have anecdotal evidence that there are Flyte deployments out there where people went this route of parsing the 2 formats to ingest logs.

Having said that, this should be quite simple implement. One idea is to have an environment variable that is checked prior to setting the logging format here. Contributions are welcome!

@VPraharsha03
Copy link

I would like to work on this, can you please assign me ? @samhita-alla

@samhita-alla
Copy link
Contributor

@VPraharsha03, are you working on creating a PR for this issue?

Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue good first issue Good for newcomers stale
Projects
None yet
Development

No branches or pull requests

5 participants