Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support latest vaex-core #3685

Closed
2 tasks done
Tracked by #4064
tekumara opened this issue May 15, 2023 · 5 comments
Closed
2 tasks done
Tracked by #4064

Support latest vaex-core #3685

tekumara opened this issue May 15, 2023 · 5 comments
Labels
enhancement New feature or request flytekit FlyteKit Python related issue good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@tekumara
Copy link

Motivation: Why do you think this is important?

To support efficient installation in python 3.10.

flytekitplugins-vaex pins to vaex-core>=4.13.0,<4.14 which doesn't have wheels for python 3.10.

This means we need to build wheels ourselves to use flytekitplugins-vaex on python 3.10.

vaex-core 4.16.1 has wheels for python 3.10

Goal: What should the final outcome look like, ideally?

flytekitplugins-vaex installs from wheels.

Describe alternatives you've considered

Building our own wheels.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@tekumara tekumara added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels May 15, 2023
@pingsutw
Copy link
Member

@tekumara Feel free to open a pr

@eapolinario eapolinario added good first issue Good for newcomers help wanted Extra attention is needed flytekit FlyteKit Python related issue and removed untriaged This issues has not yet been looked at by the Maintainers labels Jun 2, 2023
@samhita-alla samhita-alla mentioned this issue Sep 25, 2023
Closed
45 tasks
@TechWizard9999
Copy link

😊 "I'd be delighted to work on this issue, @tekumara ! Could you please assign it to me?"

@pingsutw
Copy link
Member

pingsutw commented Oct 1, 2023

Assigned to you, thanks!

@samhita-alla
Copy link
Contributor

@TechWizard9999, are you working on creating a PR for this issue?

@ericwudayi ericwudayi mentioned this issue Nov 7, 2023
Merged
8 tasks
@davidmirror-ops
Copy link
Contributor

So is this fixed with #1942?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request flytekit FlyteKit Python related issue good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tekumara @eapolinario @samhita-alla @pingsutw @davidmirror-ops @TechWizard9999