Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Imagespec Support for ContainerTasks, V1Container, SparkTasks #4070

Open
2 tasks done
Tracked by #4064
zeryx opened this issue Sep 25, 2023 · 2 comments
Open
2 tasks done
Tracked by #4064
Assignees
Labels
enhancement New feature or request

Comments

@zeryx
Copy link

zeryx commented Sep 25, 2023

Motivation: Why do you think this is important?

Image spec is good actually! It's very convenient for being able to quickly ensure that dependencies are updated - however it currently only is supported by PythonTask types.

Goal: What should the final outcome look like, ideally?

The goal would be that I could pass an imagespec variable to container_image within a ContainerTask or inside of a PodTemplate (V1Container object), which would get parsed at registration time with the correct image being attached to the container.

Describe alternatives you've considered

Copying a hardcoded image registry path ("some/path:latest") does work, however it completely removes the version control capability that imagespec offers. This also makes it hard to make incremental updates to a project, as older cached versions with the same image registry may still be around on a worker machine - which may lead to unexpected behavior.

Propose: Link/Inline OR Additional context

https://flyte.org/blog/flyte-1-8-enhanced-imagespec-integrations-and-more

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@zeryx zeryx added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Sep 25, 2023
@pingsutw pingsutw added hacktoberfest and removed untriaged This issues has not yet been looked at by the Maintainers labels Sep 26, 2023
@Kota-Karthik
Copy link

hello @zeryx @samhita-alla
I am interested in doing this issue
so kindly assign me this
Thank You : )

@samhita-alla
Copy link
Contributor

@Kota-Karthik, are you working on creating a PR for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants