Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tolerations for extended resources #6033

Merged

Conversation

troychiu
Copy link
Member

@troychiu troychiu commented Nov 20, 2024

Why are the changes needed?

Provide a way to add tolerations for extended resources so that users don't have to add it by themselves.

What changes were proposed in this pull request?

Users can specify what extended resources they would like flyte to add tolerations for them.

How was this patch tested?

  • unit tests
  • end-to-end tested

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

---------

Signed-off-by: troychiu <y.troychiu@gmail.com>
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes missing coverage. Please review.

Project coverage is 37.07%. Comparing base (45935e4) to head (4187dfc).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
...ns/go/tasks/pluginmachinery/flytek8s/pod_helper.go 91.89% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6033      +/-   ##
==========================================
+ Coverage   37.05%   37.07%   +0.02%     
==========================================
  Files        1316     1316              
  Lines      132115   132157      +42     
==========================================
+ Hits        48958    49003      +45     
+ Misses      78903    78899       -4     
- Partials     4254     4255       +1     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.10% <ø> (+0.02%) ⬆️
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.46% <ø> (ø)
unittests-flyteidl 7.25% <ø> (ø)
unittests-flyteplugins 53.81% <92.85%> (+0.09%) ⬆️
unittests-flytepropeller 42.63% <ø> (ø)
unittests-flytestdlib 57.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@troychiu troychiu marked this pull request as ready for review November 27, 2024 22:10
@troychiu troychiu merged commit 1dcc8bf into master Nov 27, 2024
52 checks passed
@troychiu troychiu deleted the union/upstream-24198f5f87ca5afcbd52ce08079ca7ff583a6fa7 branch November 27, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants