Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_eager bit to indicate eager tasks in flyte system #6041

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

pmahindrakar-oss
Copy link
Contributor

@pmahindrakar-oss pmahindrakar-oss commented Nov 21, 2024

Why are the changes needed?

To indicate explicitly in the system the tasks are using eager functionality

https://docs.flyte.org/en/latest/user_guide/advanced_composition/eager_workflows.html

The API callers eg : cli and flyteconsole can then reason about how to handle displaying eager executions

What changes were proposed in this pull request?

We are adding a bit in the task template for flytekit to indicate its registering an eager task
The other bit in node_execution is for propeller to communicate this info in event and node execution

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 37.04%. Comparing base (09a6fb8) to head (9bf93b2).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...eidl/gen/pb-go/flyteidl/admin/node_execution.pb.go 0.00% 5 Missing ⚠️
flyteidl/gen/pb-go/flyteidl/core/tasks.pb.go 0.00% 5 Missing ⚠️
flyteidl/gen/pb-go/flyteidl/event/event.pb.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6041      +/-   ##
==========================================
+ Coverage   35.41%   37.04%   +1.62%     
==========================================
  Files         999     1316     +317     
  Lines      101940   132262   +30322     
==========================================
+ Hits        36102    48992   +12890     
- Misses      62825    79008   +16183     
- Partials     3013     4262    +1249     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.07% <ø> (-0.03%) ⬇️
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.46% <ø> (ø)
unittests-flyteidl 7.23% <0.00%> (-0.02%) ⬇️
unittests-flyteplugins 53.73% <ø> (+0.01%) ⬆️
unittests-flytepropeller 42.63% <ø> (?)
unittests-flytestdlib 57.59% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

EngHabu
EngHabu previously approved these changes Nov 22, 2024
flyteidl/protos/flyteidl/event/event.proto Outdated Show resolved Hide resolved
Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
@pmahindrakar-oss pmahindrakar-oss merged commit 25c89ee into master Nov 25, 2024
51 of 52 checks passed
@pmahindrakar-oss pmahindrakar-oss deleted the add-is-eager branch November 25, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants