Skip to content
This repository has been archived by the owner on Jul 16, 2020. It is now read-only.

Add a cite field #23

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Add a cite field #23

merged 1 commit into from
Nov 3, 2017

Conversation

kofalt
Copy link
Member

@kofalt kofalt commented Nov 3, 2017

Based on an out-of-band request to display citation information of a gear.

Is this a semantic or operational change? If so:

  • Increment the version in spec/readme.md
  • After merge, tag the version and update the release page

gsfr
gsfr approved these changes Nov 3, 2017
View reviewed changes
Copy link

@gsfr gsfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lmperry Do we need more than a single string here? What if there are multiple citations? Do we just separate them by a newline?

@lmperry
Copy link
Member

lmperry commented Nov 3, 2017

LGTM: Single string is good. Could be multiple citations, but line sep or other will be fine.

@lmperry lmperry self-requested a review November 3, 2017 19:27
@kofalt kofalt merged commit 6fdc7dc into master Nov 3, 2017
@kofalt kofalt deleted the cite-field branch November 3, 2017 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lmperry lmperry lmperry approved these changes

@gsfr gsfr gsfr approved these changes

Assignees

@gsfr gsfr

@lmperry lmperry

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kofalt @lmperry @gsfr