From decc8e3fa1ce739967a9767fb78ec10d9474b56b Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Fri, 3 Jan 2025 15:59:49 +0100 Subject: [PATCH] Revert "Require an unlocked device for NFC (#40)" This reverts commit fbfd49a5201c97c6c9fffdcfb32cb181d6faa079. --- .../henneke/wearauthn/fido/nfc/NfcAuthenticatorService.kt | 7 ------- authenticator/src/main/res/values-de/strings.xml | 1 - authenticator/src/main/res/values/strings.xml | 1 - companion/src/main/res/values-de/strings.xml | 2 +- companion/src/main/res/values/strings.xml | 2 +- 5 files changed, 2 insertions(+), 11 deletions(-) diff --git a/authenticator/src/main/java/me/henneke/wearauthn/fido/nfc/NfcAuthenticatorService.kt b/authenticator/src/main/java/me/henneke/wearauthn/fido/nfc/NfcAuthenticatorService.kt index 26f7f31..b7b693e 100644 --- a/authenticator/src/main/java/me/henneke/wearauthn/fido/nfc/NfcAuthenticatorService.kt +++ b/authenticator/src/main/java/me/henneke/wearauthn/fido/nfc/NfcAuthenticatorService.kt @@ -21,7 +21,6 @@ import me.henneke.wearauthn.fido.context.AuthenticatorSpecialStatus.USER_NOT_AUT import me.henneke.wearauthn.fido.context.RequestInfo import me.henneke.wearauthn.fido.ctap2.Authenticator import me.henneke.wearauthn.ui.isDoNotDisturbEnabled -import me.henneke.wearauthn.ui.keyguardManager import me.henneke.wearauthn.ui.showToast import me.henneke.wearauthn.ui.vibrator import me.henneke.wearauthn.v @@ -76,12 +75,6 @@ class NfcAuthenticatorService : HostApduService(), CoroutineScope { } override fun processCommandApdu(commandApdu: ByteArray, extras: Bundle?): ByteArray? { - // Always allow usage on devices without a secure screen lock. - if (keyguardManager?.isDeviceLocked == true) { - notifyUnhandled() - showToast(getString(R.string.unlock_to_use_nfc)) - return null - } v { "<- ${Hex.bytesToStringUppercase(commandApdu)}" } val rawCommandApdu = commandApdu.asUByteArray() if (SELECT_FIDO_APDUS.any { rawCommandApdu.contentEquals(it) }) { diff --git a/authenticator/src/main/res/values-de/strings.xml b/authenticator/src/main/res/values-de/strings.xml index 04c02a7..edf0557 100644 --- a/authenticator/src/main/res/values-de/strings.xml +++ b/authenticator/src/main/res/values-de/strings.xml @@ -81,6 +81,5 @@ Log-Level wählen Auf \"Debug\" oder \"Verbose\" können Logs persönliche Informationen enthalten. Bluetooth-Berechtigung nicht erteilt - Für WearAuthn entsperren diff --git a/authenticator/src/main/res/values/strings.xml b/authenticator/src/main/res/values/strings.xml index 59df0ea..a1910a7 100644 --- a/authenticator/src/main/res/values/strings.xml +++ b/authenticator/src/main/res/values/strings.xml @@ -95,5 +95,4 @@ Choose a log level Logs may contain personal information on \"Debug\" or \"Verbose\". Bluetooth permission not granted - Unlock to use WearAuthn diff --git a/companion/src/main/res/values-de/strings.xml b/companion/src/main/res/values-de/strings.xml index e5af77a..5719a17 100644 --- a/companion/src/main/res/values-de/strings.xml +++ b/companion/src/main/res/values-de/strings.xml @@ -1,6 +1,6 @@ - Letzte ÄnderungenUnveröffentlicht
• NFC-Funktionalität setzt jetzt ein entsperrtes Gerät voraus

Version 0.9.19
• Anpassungen für aktuelle Android-Versionen
• Absturz beim Zurücksetzen behoben
• Absturz durch spezielle Bluetooth-Geräte behoben

Version 0.9.17
• Initialer CTAP 2.1-Support
• Passwortabfrage erfolgt nun vor dem Bestätigungsdialog
• HMAC-Erweiterung berücksichtigt nun das Ergebnis der Nutzerverifikation

Version 0.9.16
• Zuverlässigkeit der Bluetooth-Verbindung und Zifferblatt-Verknüpfung verbessert
• Kleinere Verbesserungen an der Übersetzung

Version 0.9.15
• Aktualisierung der Abhängigkeiten aufgrund von Inkompatibilitäten
• Anpassung einer Übersetzung, die einen Button verdeckte

Version 0.9.14
• Deutsche Übersetzung
• Verbesserte Texte und Datenschutzrichtlinien
• Fehlender Email-Text bei \"Problem melden\" ergänzt

Version 0.9.13
• Compatibility with Microsoft AAD
• Compliance with CTAP 2.1

Version 0.9.12
• Bugfixes related to attestation
• Fixed a crash when user verification times out over NFC
• Fixed display of creation dates of stored credentials

Version 0.9.11
• Bugfix for watches on Android P+

Version 0.9.10
• Manage your single-factor credentials on the watch

Version 0.9.9
• Improved interoperability with Windows 10
• Added RP ID to resident key metadata

Version 0.9.8
• Improved the UI for resets and errors

Version 0.9.7
• UI improvements in the phone app

Version 0.9.6
• Fixed a missing toast after a single CTAP2 assertion via NFC

Version 0.9.5
• Added support for transaction confirmation via the "txAuthSimple" extension

Version 0.9.4
• Added support for offline login via the "hmac-secret" extension
• Fixed a crash when extensions were requested with an assertion]]> + Letzte ÄnderungenVersion 0.9.19
• Anpassungen für aktuelle Android-Versionen
• Absturz beim Zurücksetzen behoben
• Absturz durch spezielle Bluetooth-Geräte behoben

Version 0.9.17
• Initialer CTAP 2.1-Support
• Passwortabfrage erfolgt nun vor dem Bestätigungsdialog
• HMAC-Erweiterung berücksichtigt nun das Ergebnis der Nutzerverifikation

Version 0.9.16
• Zuverlässigkeit der Bluetooth-Verbindung und Zifferblatt-Verknüpfung verbessert
• Kleinere Verbesserungen an der Übersetzung

Version 0.9.15
• Aktualisierung der Abhängigkeiten aufgrund von Inkompatibilitäten
• Anpassung einer Übersetzung, die einen Button verdeckte

Version 0.9.14
• Deutsche Übersetzung
• Verbesserte Texte und Datenschutzrichtlinien
• Fehlender Email-Text bei \"Problem melden\" ergänzt

Version 0.9.13
• Compatibility with Microsoft AAD
• Compliance with CTAP 2.1

Version 0.9.12
• Bugfixes related to attestation
• Fixed a crash when user verification times out over NFC
• Fixed display of creation dates of stored credentials

Version 0.9.11
• Bugfix for watches on Android P+

Version 0.9.10
• Manage your single-factor credentials on the watch

Version 0.9.9
• Improved interoperability with Windows 10
• Added RP ID to resident key metadata

Version 0.9.8
• Improved the UI for resets and errors

Version 0.9.7
• UI improvements in the phone app

Version 0.9.6
• Fixed a missing toast after a single CTAP2 assertion via NFC

Version 0.9.5
• Added support for transaction confirmation via the "txAuthSimple" extension

Version 0.9.4
• Added support for offline login via the "hmac-secret" extension
• Fixed a crash when extensions were requested with an assertion]]> Gekauft Kaufen Uhr-App nicht installiert diff --git a/companion/src/main/res/values/strings.xml b/companion/src/main/res/values/strings.xml index f0dc1d6..21be2f1 100644 --- a/companion/src/main/res/values/strings.xml +++ b/companion/src/main/res/values/strings.xml @@ -1,7 +1,7 @@ WearAuthn - Recent changesUnreleased
• NFC functionality now requires an unlocked device

Version 0.9.19
• Adaptions for recent Android versions
• Fix a crash during reset
• Fix a crash with specific Bluetooth devices

Version 0.9.17
• Initial CTAP 2.1 support
• User verification is performed before user presence check
• HMAC secret extension takes user verification result into account

Version 0.9.16
• Improved Bluetooth and complication reliability

Version 0.9.15
• Updated dependencies to fix incompatibilities

Version 0.9.14
• German translation
• Improved UI strings and privacy policy
• Added missing email body for \"Report a bug\"

Version 0.9.13
• Compatibility with Microsoft AAD
• Compliance with CTAP 2.1

Version 0.9.12
• Bugfixes related to attestation
• Fixed a crash when user verification times out over NFC
• Fixed display of creation dates of stored credentials

Version 0.9.11
• Bugfix for watches on Android P+

Version 0.9.10
• Manage your single-factor credentials on the watch

Version 0.9.9
• Improved interoperability with Windows 10
• Added RP ID to resident key metadata

Version 0.9.8
• Improved the UI for resets and errors

Version 0.9.7
• UI improvements in the phone app

Version 0.9.6
• Fixed a missing toast after a single CTAP2 assertion via NFC

Version 0.9.5
• Added support for transaction confirmation via the "txAuthSimple" extension

Version 0.9.4
• Added support for offline login via the "hmac-secret" extension
• Fixed a crash when extensions were requested with an assertion]]> + Recent changesVersion 0.9.19
• Adaptions for recent Android versions
• Fix a crash during reset
• Fix a crash with specific Bluetooth devices

Version 0.9.17
• Initial CTAP 2.1 support
• User verification is performed before user presence check
• HMAC secret extension takes user verification result into account

Version 0.9.16
• Improved Bluetooth and complication reliability

Version 0.9.15
• Updated dependencies to fix incompatibilities

Version 0.9.14
• German translation
• Improved UI strings and privacy policy
• Added missing email body for \"Report a bug\"

Version 0.9.13
• Compatibility with Microsoft AAD
• Compliance with CTAP 2.1

Version 0.9.12
• Bugfixes related to attestation
• Fixed a crash when user verification times out over NFC
• Fixed display of creation dates of stored credentials

Version 0.9.11
• Bugfix for watches on Android P+

Version 0.9.10
• Manage your single-factor credentials on the watch

Version 0.9.9
• Improved interoperability with Windows 10
• Added RP ID to resident key metadata

Version 0.9.8
• Improved the UI for resets and errors

Version 0.9.7
• UI improvements in the phone app

Version 0.9.6
• Fixed a missing toast after a single CTAP2 assertion via NFC

Version 0.9.5
• Added support for transaction confirmation via the "txAuthSimple" extension

Version 0.9.4
• Added support for offline login via the "hmac-secret" extension
• Fixed a crash when extensions were requested with an assertion]]> https://github.com/fmeum/WearAuthn/issues/new?assignees=fmeum&template=bug_report.md Purchased Purchase pending