Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

got warning in fmt 8.1.0 [-Werror=extra] #2697

Closed
ItayBar03 opened this issue Jan 4, 2022 · 4 comments
Closed

got warning in fmt 8.1.0 [-Werror=extra] #2697

ItayBar03 opened this issue Jan 4, 2022 · 4 comments

Comments

@ItayBar03
Copy link

fmt-src/include/fmt/format.h:539:27: error: enumeral and non-enumeral type in conditional expression [-Werror=extra]
I use "treat warnings as error" so I can't use this version
@vitaut
Copy link
Contributor

vitaut commented Jan 5, 2022

What compiler version do you use?

@ItayBar03
Copy link
Author

in my project I use two compilers for two chips, xtensa-esp32s2-elf-gcc works fine, and the riscv32-esp-elf-gcc is the problematic

@phprus
Copy link
Contributor

phprus commented Jan 5, 2022

@vitaut I guess the problem is in the type of invalid_code_point.
Maybe change type of invalid_code_point from enum to constexpr uint32_t?

@vitaut
Copy link
Contributor

vitaut commented Jan 5, 2022

Should be fixed in dbbd711.

@vitaut vitaut closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phprus @vitaut @ItayBar03