-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken operator<< support in 8.x #2759
Comments
my bad, i missed the FMT_DEPRECATED_OSTREAM |
@andijcr |
If you define The preferred mechanism is to define a |
@mwinterb For instance, I'm trying to build Open3D, which has such a file TensorMap.cpp , in which there are two occurrences of fmt::format , and they seem to be 2 different formatter from the same class. It looks it's more friendly for the end users by using the deprecated way??? |
It's not an issue of friendliness, the deprecated way caused problems, see #2357. Additionally, this loop https://github.com/isl-org/Open3D/blob/174886a56cb8897ccb494272a2546c56527c65ce/cpp/open3d/t/geometry/TensorMap.cpp#L67-L68 is pointless since the return value of format is discarded, which is a warning in recent versions of fmt, and it seems as though Open3D compiles with warnings as errors. |
https://gcc.godbolt.org/z/bfvGf8bb4
it seems that fmt v7 could use friend operator<< as a fallback formatter, while with v8 it fails with
The text was updated successfully, but these errors were encountered: