-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning C4251: class 'fmt::v8::file' needs to have dll-interface #2796
Comments
Note: I don't have the warning with 7.1.3, but have the warning with 8.0.0, so something seems to have changed between those two versions causing the warning. |
Oh, I see what has changed: it's the class |
This is the commit making the change, which apparently missed adding FMT_API to |
Could you submit a PR to add FMT_API where necessary? |
@vitaut : yes, done! |
I get the following warning with fmt 8.1.1 (or latest commit) on MSCV 2019 (when compiling as a shared lib):
The class
file
indeed isn't declared withFMT_API
, although all its non-inline member functions are. The warning goes away if I addFMT_API
to the whole class, and remove all the seperate per-functionFMT_API
.Was there a good reason for not exporting the whole class, or should I make a PR exporting the whole class?
The text was updated successfully, but these errors were encountered: