Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FMT_CONSTEXPR20 should be conditionally enabled for Visual Studio compiler family #2958

Closed
Dani-Hub opened this issue Jul 3, 2022 · 1 comment
Closed

FMT_CONSTEXPR20 should be conditionally enabled for Visual Studio compiler family #2958

Dani-Hub opened this issue Jul 3, 2022 · 1 comment

Comments

@Dani-Hub
Copy link
Contributor

Dani-Hub commented Jul 3, 2022

Currently the preprocessor definition FMT_CONSTEXPR20 is always defined empty for the MSVC compiler family albeit at least VS 2022 should support it. Is the omission intentionallly or just due to the lack of experience?

In the latter case and assuming that there is currently no active work on this (I didn't find a relevant issue by searching for FMT_CONSTEXPR20) I'm volunteering to work on this topic. Please let me know, whether a corresponding PULL request would be welcome.
@phprus phprus mentioned this issue Jul 3, 2022
Merged
@vitaut
Copy link
Contributor

vitaut commented Jul 4, 2022

Fixed in #2960 (thanks @phprus).

@vitaut vitaut closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dani-Hub @vitaut