Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install doesn't install header files #3517

Closed
mborn-adi opened this issue Jun 30, 2023 · 4 comments · Fixed by #3523
Closed

Install doesn't install header files #3517

mborn-adi opened this issue Jun 30, 2023 · 4 comments · Fixed by #3523

Comments

@mborn-adi
Copy link
Contributor

On Windows, install only installs everything except the header files. In CMakeLists.txt, the install is set up like this:

  # Install the library and headers.
  install(TARGETS ${INSTALL_TARGETS} EXPORT ${targets_export_name}
          LIBRARY DESTINATION ${FMT_LIB_DIR}
          ARCHIVE DESTINATION ${FMT_LIB_DIR}
          PUBLIC_HEADER DESTINATION "${FMT_INC_DIR}/fmt"
          RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})

But nowhere else are the header files marked "PUBLIC_HEADER".

Adding

set_property(TARGET fmt PROPERTY PUBLIC_HEADER ${FMT_HEADERS})

in line 289 right after

add_library(fmt::fmt ALIAS fmt)

does just that. But cmake is not my strongest suit.

Best Regards,
Mathias

@vitaut
Copy link
Contributor

vitaut commented Jul 1, 2023

I was able to repro this on macOS and it looks like a recent regression related to modules work.

@rxguy
Copy link

rxguy commented Jul 1, 2023

I am getting this today with Fedora Linux.

@vitaut vitaut changed the title Install doesn't install header files on MS-Windows Install doesn't install header files Jul 1, 2023
@vitaut
Copy link
Contributor

vitaut commented Jul 12, 2023

Header installation was working on 75f3b1c.

@vitaut
Copy link
Contributor

vitaut commented Jul 12, 2023

Bisected the regression to 13156e5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants