Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fresh update of CMakeLists.txt incorrect? #3714

Closed
anvvv opened this issue Nov 13, 2023 · 2 comments
Closed

Fresh update of CMakeLists.txt incorrect? #3714

anvvv opened this issue Nov 13, 2023 · 2 comments

Comments

@anvvv
Copy link

anvvv commented Nov 13, 2023 •
edited
Loading

I am having issues compiling using CMake (3.16).

CMake Error at CMakeLists.txt:397 (install):
install TARGETS given unknown argument "FILE_SET".

This is from a freshly cloned repository, master branch.

My conjecture is that FILE_SET only gets defined for versions 3.28 and above, as per line 109.

This change is quite fresh in master (from one hour ago) , in https://github.com/fmtlib/fmt/blob/master/CMakeLists.txt

It seems to have been introduced with cbb18c2
@artorhem
Copy link

I have exactly the same issue.

@vitaut
Copy link
Contributor

vitaut commented Nov 14, 2023

Fixed in 045b05d.

@vitaut vitaut closed this as completed Nov 14, 2023
@vitaut vitaut mentioned this issue Nov 14, 2023
Merged
@BrewTestBot BrewTestBot mentioned this issue Jan 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vitaut @anvvv @artorhem