Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to detect trunk clang to support pre-compiled format #4000

Closed
yujincheng08 opened this issue Jun 7, 2024 · 3 comments · Fixed by #4001
Closed

Failed to detect trunk clang to support pre-compiled format #4000

yujincheng08 opened this issue Jun 7, 2024 · 3 comments · Fixed by #4001

Comments

@yujincheng08
Copy link
Contributor

This one does not compile: https://godbolt.org/z/x315Y9q8Y

However, once we manually define FMT_USE_NONTYPE_TEMPLATE_ARGS, it does compile: https://godbolt.org/z/nf1YPfMvG

@yujincheng08 yujincheng08 changed the title Failed to detech trunk clang to supoort pre-compiled format Failed to detect trunk clang to supoort pre-compiled format Jun 7, 2024
@vitaut
Copy link
Contributor

vitaut commented Jun 8, 2024

The compiler reports class types in non-type template parameters as not supported: https://godbolt.org/z/5G1ro8G35. But we could check the clang version explicitly and enable this anyway (a PR is welcome).

@yujincheng08
Copy link
Contributor Author

You are right, https://en.cppreference.com/w/cpp/compiler_support also mentions this.

@yujincheng08
Copy link
Contributor Author

PRed

@vitaut vitaut changed the title Failed to detect trunk clang to supoort pre-compiled format Failed to detect trunk clang to support pre-compiled format Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants