Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting C++17 std::string_view #570

Closed
feroldi opened this issue Sep 17, 2017 · 2 comments
Closed

Supporting C++17 std::string_view #570

feroldi opened this issue Sep 17, 2017 · 2 comments

Comments

@feroldi
Copy link
Contributor

feroldi commented Sep 17, 2017

Any plans on this? It'd be useful to support std::string_view now that C++17 is practically done, and at least GCC and Clang have it implemented already.

I did a test[1] and it seems to work fine alongside fmt::StringRef.

[1] https://github.com/thelostt/fmt/tree/feature-string-view
@vitaut
Copy link
Contributor

vitaut commented Sep 17, 2017

I don't have any specific plans but PRs are very welcome.

@feroldi
Copy link
Contributor Author

feroldi commented Sep 17, 2017

Closed. See #571.

@feroldi feroldi closed this as completed Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @feroldi