Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIN validation #32

Closed
justincrow opened this issue Sep 12, 2018 · 5 comments
Closed

PIN validation #32

justincrow opened this issue Sep 12, 2018 · 5 comments

Comments

@justincrow
Copy link

justincrow commented Sep 12, 2018

Hi,

I wondered if you'd thought of adding pluggable validation rules when choosing a PIN, such as non-sequential numbers, and non-repeating numbers.

Or perhaps just a couple of new parameters that allow restricting the use of sequential numbers and all repeating numbers?

If not, would you accept a pull request?

Thanks.

@jeremy-farnault
Copy link
Contributor

Hi,

This is a really cool idea :). I'll give it a thought during the weekend.
Thanks!

Cheers
Jeremy

@timt
Copy link

timt commented Oct 3, 2018

Hi,

Great idea. Are you likely to add this feature soon? Would you like a pull request for it?

--Tim

@jeremy-farnault
Copy link
Contributor

Hi,

Sorry for the delay @timt .
I started to work on this today. Will keep in touch.

Cheers,
Jeremy

@jeremy-farnault
Copy link
Contributor

Hi,

This is done in version 1.7.0 :).
I chose to go for the RegExp solution.
You can now use validationRegex property to check the PIN entered by the user and the titleValidationFailed one to tweak the title displayed if the check fails.

Thanks again for this idea :).

Cheers,
Jeremy

@justincrow
Copy link
Author

justincrow commented Oct 10, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants