Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Pin Code after account was locked #38

Closed
marla-singer opened this issue Sep 25, 2018 · 2 comments
Closed

Clear Pin Code after account was locked #38

marla-singer opened this issue Sep 25, 2018 · 2 comments

Comments

@marla-singer
Copy link
Contributor

Steps for reproduce

  1. Try to login and enter PIN Code incorrectly some times so access is locked
  2. Wait until the time is over and Enter your PIN Code step is shown again
  3. See pict. Note that the 4 PIN Code dots are filled/completed. The user has to manually deleted them before entering the 4 digits again

image

  1. It would be nice to show the 4 dots cleared as when first requested

image

Solution

I've made the dirty hack to fix it and I'm using that
https://github.com/marla-singer/react-native-pincode/blob/2a39d1bff9d560c9d860b1aa05fc9458ec063fb3/src/PinCode.tsx#L137

If it's okay for you then I can prepare PR. If it isn't then I'm looking forward to see your changes and a new version of the library :)

@jeremy-farnault
Copy link
Contributor

Hi,

Solution is perfectly fine by me :). I had a bit of time this morning so I integrated your solution and published a new version.

Thanks a lot for that :)

Cheers
Jeremy

@marla-singer
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants