Removed iap, feedback email, dummy project #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlndnn
approved these changes
Mar 17, 2021
Open
|
I converted this to a draft, since it's gotten behind the main branch and I haven't heard back from @gdryke. It'd still be good to get these cleanup improvements merged, so anyone who stumbles upon this should feel free to update the branch and re-submit this. |
Closed
|
This has gone stale and the conflicts are growing, so at this point it'd be easier for someone to create a new PR. Closing this one to keep the repo tidy & relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just starting on some clean up! I'm not sure on any project direction...but the IAP didn't feel great to me for an open source project, the feedback email was just unsafe (the EverNote creds need to go next, also a question on product direction), and the dummy project seemed useless?
Still seems to build fine though!