Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect when previous merge is already in the load order #1

Closed
focustense opened this issue Jun 16, 2021 · 2 comments
Closed

Detect when previous merge is already in the load order #1

focustense opened this issue Jun 16, 2021 · 2 comments
Labels
easynpc Issues/requests relating the EasyNPC app enhancement New feature or request
Milestone

Comments

@focustense
Copy link
Owner

There is currently nothing to prevent loading a previous merge and making that a dependency of the new merge - probably by accident.

Plugins that are actually merges previously created by the app should either be disabled in the load order screen, or simply ignored. This is similar to how a Bashed Patch can't be imported as its own dependency.

@focustense focustense added the enhancement New feature or request label Jun 16, 2021
@focustense focustense added this to the v0.1-alpha milestone Jun 16, 2021
@focustense focustense added the easynpc Issues/requests relating the EasyNPC app label Jun 16, 2021
@focustense focustense modified the milestones: v0.1-alpha, v0.9-beta Jun 20, 2021
@focustense
Copy link
Owner Author

I'm going to add one bit to the scope here, which is labeling and preventing the inclusion of plugins with missing masters. A few users ran into this issue and it's very hard to provide clear and useful error messaging after the fact; it makes much more sense to provide a UI like xEdit or Mod Organizer where those plugins are disabled or crossed out.

Although Mutagen is perfectly capable of reading plugins without the masters loaded, EasyNPC is very quickly going to try to actually locate those master records, and fail every time that happens.

@focustense
Copy link
Owner Author

Fixed in 1a80c14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easynpc Issues/requests relating the EasyNPC app enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant