Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some DLC changes are reverted on the default settings #19

Closed
ATantalizedLion opened this issue Jun 25, 2021 · 1 comment
Closed

Some DLC changes are reverted on the default settings #19

ATantalizedLion opened this issue Jun 25, 2021 · 1 comment
Labels
bug Something isn't working easynpc Issues/requests relating the EasyNPC app

Comments

@ATantalizedLion
Copy link

image
image

This problem seems to mostly (almost exclusively) affect some of the Vampires in the Dawnguard DLC. It looks like the changing of the head part causes the DLC to be labeled as a face mod, overriding the perk, voice, actor effects and faction changes in these NPCs.

Maybe some logic could be added to check if the mod(or DLC in this case) makes any changes to the NPCs relative to its own masters. Though I am not sure how viable this is performance-wise

@focustense
Copy link
Owner

This is due to a silly bug I accidentally created in 481d8de. It's specifically this line, where instead of checking the actual name of the default override to see if it's an existing master (very much like the check you're suggesting), it checks an uninitialized variable due to there not being any ITM/ITPOs in the load order.

There's not even any reason for that logic to be there, since the implementation was switched from tracking the plugin name as a separate variable to simply checking that the default override is not null.

I've got a fix tested and will have it pushed soon. Pretty much just reverts that line to the original implementation (with the added null check) which didn't have this bug in the first place.

@focustense focustense added bug Something isn't working easynpc Issues/requests relating the EasyNPC app labels Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easynpc Issues/requests relating the EasyNPC app
Projects
None yet
Development

No branches or pull requests

2 participants