-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser blockers #20
Comments
Having the same issue... |
Second this issue, present in Electron app |
Same for me |
|
Getting the same error |
This issue also surfaces when transitively loading brotli from a jest test of a purely backend node library. |
I also get this error message |
Looks like this project is dead... I switched to LZ4 |
I've been using LZ4 (npm package |
Yapacağınız işi sikeyim kusura bakmayın |
One note that might be useful to others: this only affects the compress build, not the decompress build. |
At this point, we could probably consider WASM as the compile target instead. I guess we could keep a fallback for IE 11 as well but all the modern browsers have WASM now. https://caniuse.com/#feat=wasm |
Now uses wasm #51 |
There's a
Browser.T
referenced in the emscripten runtime output of the current published build that doesn't refer to anything as far as I can tell, causing the output of either browserify or webpack to produce the errorUncaught ReferenceError: Browser is not defined
.Rebuilding the library fixes this, but adds an error that encode.js.mem can't be found. Adding
Module['readAsync']=function(_,f){f(Module['readBinary']())};
seems to fix this, but then I getUncaught Error: [ReadHuffmanCode] invalid num_codes or space
.You'd lose the benefits of compressing the memfile, but it may be worth considering switching to emscripten's upcoming
SINGLE_FILE
flag that does base64 encoding if there's no other workaround. (Is there actually a space advantage to compressing it at this stage vs leaving it to be brotli'd/gzip'd at the same time as the rest of the JS in the user's build pipeline? I'd expect the latter to at least be slightly more CPU-efficient since it'd be decompressed by native code.)Misc issues:
The
bro
command in the makefile no longer works with the latest brotli; the equivalent command is nowbrotli -c
. (Alternatively, there's always./vendor/brotli/bin/bro
.)NO_BROWSER
has been removed from emscripten.The text was updated successfully, but these errors were encountered: