Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowplayer zoom issue #738

Closed
foliovision opened this issue Jun 27, 2022 · 0 comments
Closed

Flowplayer zoom issue #738

foliovision opened this issue Jun 27, 2022 · 0 comments

Comments

@foliovision
Copy link
Owner

Original issue link: #1056 Flowplayer zoom issue


RopoMen commented on Sep 30, 2016

Hi,

I'm using Reveal.js with Flowplayer and noticed that Flowplayer is not working perfectly when zoom / scale is used (depends on the browser which can be used)

If you seek from timeline the mouse cursor position and timeline percentage value are not looking correct. Also shown time is not in right position.

I made JSFiddle about this issue

I made this fiddle with Mac+Chrome, but it is broken also in Windows+Chrome and Mac+Safari. Mac+Firefox will work correctly.


nnarhinen commented on Oct 7, 2016

https://bugs.chromium.org/p/chromium/issues/detail?id=429140 This is most likely related


nnarhinen commented on Oct 7, 2016

http://codepen.io/anon/pen/gwvQEp?editors=1111

simple reproducable fiddle..


nnarhinen commented on Oct 7, 2016

We are not alone with the problem: zeroclipboard/zeroclipboard#149


nnarhinen commented on Oct 7, 2016

http://codepen.io/anon/pen/LRQrAV?editors=1111 This seems to fix this, will try to apply to flowplayer code.


nnarhinen commented on Oct 7, 2016

Ok, so here are the symptoms:

  • common.width(root) is off by the zoom factor
  • common.width(timeline) is nothing seemingly reasonable

And because the timeline offset calculation does not return anything remotely reasonable it becomes impossible to do any calculations based on the mouse position.

As much as I'd like to fix this properly I must deem this a browser bug and the only decent workaround is to enforce zoom: 1 for the root element.


nnarhinen commented on Oct 7, 2016

Buggy zoom: http://demos.dev94.flowplayer.us/bug/1056.html
Enforced zoom: 1: http://demos.1058f.flowplayer.me/bug/1056.html


RopoMen commented on Oct 11, 2016

Good catch. I was looking in to YouTube iframe embed and why it's working correctly. Reason is that zoom: 1; because iframe has its own document and its default zoom is 1. And because fp is not embedded inside iframe, you need to force zoom: 1 in fp root elem. TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant