Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: new keymaps for Profile filter/sort #133

Closed
1 task done
jdrouhard opened this issue Dec 23, 2022 · 1 comment
Closed
1 task done

feature: new keymaps for Profile filter/sort #133

jdrouhard opened this issue Dec 23, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jdrouhard
Copy link
Contributor

Did you check docs the docs?

  • I have read all the lazy docs

Is your feature request related to a problem? Please describe.

Recent changes to add filtering and sorting for the Profile view added <C-s> and <C-f>.

<C-f> is generally used for "page forward" (scrolls more than <C-d>) and is generally the mapping I use for scrolling. Normally I'm ok with a plugin adding key mappings that take over common keys, but for this one, it is just jarring enough for me to open the issue :)

Especially since scrolling is necessary in the Lazy window, I'm suggesting that either a different keymap be chosen, or make the keymaps configurable for the Lazy window.

Tangentially related, but <C-s> is sometimes interpreted by terminal emulators as XOFF (flow control command) and can appear to "freeze" terminal emulators that still do that.

Describe the solution you'd like

Either a new keymap for the filter or some way to override the one Lazy uses.

Describe alternatives you've considered

N/A

Additional context

No response

@jdrouhard jdrouhard added the enhancement New feature or request label Dec 23, 2022
@folke
Copy link
Owner

folke commented Dec 23, 2022

I refactored the ui code to make it all configurable, but I'm not planning on making this public or adding anything about it in the readme. However, you can customize your mappings with:

local ViewConfig = require("lazy.view.config")
ViewConfig.keys.profile_filter = "<C-f>"
ViewConfig.keys.profile_sort = "<C-s>"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants