Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix incorrect LuaLS types #1339

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

lucario387
Copy link
Contributor

Without the added parentheses, the type were resolved to

(field) keys: (
  |string
  |LazyKeysSpec[]
  |fun(self: LazyPlugin, keys: string[]):string
  |LazyKeys[]
  |string[]
)?

With the paren, it now correctly resolves to

(field) keys: (
  |string
  |LazyKeysSpec[]
  |fun(_: LazyPlugin, keys: string[]):(string|LazyKeys)[]
  |string[]
)?

@folke folke merged commit 5aea4e7 into folke:main Mar 7, 2024
@folke
Copy link
Owner

folke commented Mar 7, 2024

thanks!

@lucario387 lucario387 deleted the fix/keys-type branch March 8, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants