fix(plugin): Make the local_spec check reject similar config module names
#1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(e.g. config modules named `lazy.lualine`, `user.lazy.lua`, etc. will not be treated as local specs)
A valid local import spec never has `spec.import == M.LOCAL_SPEC` because by the time we do the check, we know that `find_local_spec()` succeeded (if it didn't, the spec:cond() check would have failed). Thus we only need to check if the modname ends with `'/' .. M.LOCAL_SPEC`.
|
Thank you for reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug found by a user on r/neovim introduced by e2e10d9 where a
modnamesuch asuser.lazy.lualinewould match thelocal_speccheck for.lazy.lua.I've modified the check to account for modnames such as
user.lazy.lualineandplugins.lazy.lua. Although while I was doing this, I was wondering if the spec should store a psuedo-private bool about being a local_spec or not instead? I didn't want to make the diff too big though and this seems performant enough to me so I'm just submitting this for now.