fix(config): only enable rocks if luarocks is installed

[mehalter]

This disables rocks packages by default if luarocks is not installed on the user's system

[mehalter]

Background: luarocks can take a bit of forethought from the user mainly because they not only have to install luarocks but also make sure that they have installed lua v5.1 on their system as well as the development package with headers for it to work. This assumes that if the user has installed luarocks then they have put this forethought, if not the plugin manager works totally fine without it. Another potential thing that could be added is a check somehow to see if the user's system has lua v5.1 installed with the correct system headers or else they get hit with a bunch of errors that luarocks cannot find the appropriate header files. Especially since in all of the operating systems I have checked the default Lua version installed is typically newer and causes this error. For RHEL you have to install compat-lua, Arch you need to install lua51, etc.

[folke]

I'm not sure this is a good idea.
When users would add neorg for example, it would simply be broken and users would submit issues in the lazy.nvim or neorg repo.

As long as the user doesn't add a plugin that has a rockspec, this isn't really an issue?

Or do you have examples of plugins that cause issues right now?

A plugin with a rockspec will only use the rockspec if it has deps or if it has an advanced build process.

If there's any high profile plugins out there that have one of these things, but dont actually need a rockspec, then that plugin should add a lazy.lua file.

[mehalter]

Yeah plenary is a great example as is telescope

[mehalter]

I suppose time will tell if others run into this! Definitely understand the pause on disabling luarocks out of the box if it's not installed. I'll go ahead and close this for now and will follow the issues to see if anything comes up as people start adopting the new version.

Super super happy with this new addition! Thanks so much for this!

[folke]

I've just added special support for plenary.nvim.
plenary itself and a plugin that only has plenary as a dep will now install normally

[folke]

So this also skips luarocks for telescope.nvim