Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lockfile): ensure newline at EOF for lockfile #1639

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

ethanwu10
Copy link
Contributor

Description

The lockfile currently does not end with a newline at EOF. Text files should end with a newline. This also lets you manually edit the lockfile in vim without 'fixeol' creating a spurious change for the added newline.

This change however will create a change in users' lockfiles adding a newline upon updating, but since the lockfile would be changing anyways to update lazy.nvim itself, this is likely acceptable.

Related Issue(s)

none

Screenshots

N/A

Text files should end with a newline. This also lets you manually edit
the lockfile in vim without 'fixeol' creating a spurious change for the
added newline.

This change however will create a change in users' lockfiles adding a
newline upon updating, but since the lockfile would be changing anyways
to update lazy.nvim itself, this is likely acceptable.
@folke folke merged commit 7ed9f71 into folke:main Jul 13, 2024
2 checks passed
@folke
Copy link
Owner

folke commented Jul 13, 2024

ty

folke pushed a commit that referenced this pull request Jul 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[11.11.1](v11.11.0...v11.11.1)
(2024-07-13)


### Bug Fixes

* **config:** check for lib64. Fixes
[#1343](#1343)
([93499c5](93499c5))
* **lockfile:** ensure newline at EOF for lockfile
([#1639](#1639))
([7ed9f71](7ed9f71))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ethanwu10 ethanwu10 deleted the lockfile-nl-at-eof branch July 13, 2024 21:54
@ethanwu10 ethanwu10 restored the lockfile-nl-at-eof branch July 13, 2024 21:54
@ethanwu10 ethanwu10 deleted the lockfile-nl-at-eof branch July 13, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants