-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: allow per task wait #1635
Comments
FYI, there is already a 'wait' stanza, unfortunately, that's not good enough. error we got
This typically means we've burst too much :( |
Line 638 in d1de92d
The second concurrency option exists. It may work. |
I already have
still too fast once checker is in working |
Oh.. |
I'll see to add something for this this evening |
I have a similar issue. In my case, I use HDD for disk and have limited network bandwidth. |
@mimikun what do you mean with previous behavior? |
Before this commit: 0614ca6 After this commit, my plugin update speed, which was set to concurrency = 1, became incredibly slow (I've now tweaked it a bit and it's gotten a bit better. about: https://github.com/mimikun/dotfiles/blob/f64ba2b10333a65bc06e76aeefbb15f8ecdcdc99/dot_config/nvim/lua/core/lazyvim.lua#L4-L17). |
Thank you folke! Life saving for us programming inside controlled environments, now I can have a way to tweak to the near allowed capacity and not got banded by our network policy! One thing to point out, my previous config was like this
The Thank you again!! |
🤖 I have created a release *beep* *boop* --- ## [11.12.0](v11.11.1...v11.12.0) (2024-07-16) ### Features * **git:** added git network throttle to limit network related git ops per interval. Closes [#1635](#1635) ([d731a6b](d731a6b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Did you check the docs?
Is your feature request related to a problem? Please describe.
no, not a problem per sa, but it is a fairly unfortunate situation. We have workstations in cloud that only has limited network bandwidth and the VMs can't allow short high burst of egress traffic. Unfortunately, even if with checker.concurrency = 1, since each check is really fast, the overall speed is still too fast and bursty.
Describe the solution you'd like
It would be nice along with concurrency, we could specify a wait interval to further slow checkers down. e.g. if we could achieve some 1 task per 1s, that should help tremendously, or every time we just got 403 from github.
Describe alternatives you've considered
It does not appear one from the lazy doc. I've limited the task to 1 and still just too fast. Most of time, before all working checks done, the network already got disconnected.
Additional context
No response
The text was updated successfully, but these errors were encountered: