Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: log breaks with log.showSignature = true #218

Closed
3 tasks done
swsnr opened this issue Dec 28, 2022 · 1 comment · Fixed by #197
Closed
3 tasks done

bug: log breaks with log.showSignature = true #218

swsnr opened this issue Dec 28, 2022 · 1 comment · Fixed by #197
Labels
bug Something isn't working

Comments

@swsnr
Copy link

swsnr commented Dec 28, 2022

Did you check docs and existing issues?

  • I have read all the lazy docs
  • I have searched the existing issues of lazy
  • I have searched the exsiting issues of the plugin I have a problem with

Neovim version (nvim -v)

0.8.1

Operating system/version

Arch Linux

Describe the bug

:Lazy log fails with the following error when log.showSignature is true in gitconfig.

Error executing vim.schedule lua callback: ...local/share/nvim/lazy/lazy.nvim/lua/lazy/view/render.lua:416: at
tempt to index local 'msg' (a nil value)
stack traceback:
        ...local/share/nvim/lazy/lazy.nvim/lua/lazy/view/render.lua:416: in function 'log'
        ...local/share/nvim/lazy/lazy.nvim/lua/lazy/view/render.lua:401: in function 'tasks'
        ...local/share/nvim/lazy/lazy.nvim/lua/lazy/view/render.lua:384: in function 'plugin'
        ...local/share/nvim/lazy/lazy.nvim/lua/lazy/view/render.lua:231: in function 'section'
        ...local/share/nvim/lazy/lazy.nvim/lua/lazy/view/render.lua:71: in function 'update'
        .../.local/share/nvim/lazy/lazy.nvim/lua/lazy/view/init.lua:124: in function 'fn'
        ...basti/.local/share/nvim/lazy/lazy.nvim/lua/lazy/util.lua:68: in function <...basti/.local/share/nvi
m/lazy/lazy.nvim/lua/lazy/util.lua:67>

Disabling log.showSignature properly shows the log.

Steps To Reproduce

  1. git config --global log.showSignature true
  2. Run :Lazy log in neovim

Expected Behavior

No error 😉

I don't expect to actually see the signature in Lazy (even though that'd be pretty cool 😇 ) but it'd be helpful if Lazy could disable showSignature for its git log calls.

Repro

@swsnr swsnr added the bug Something isn't working label Dec 28, 2022
@folke folke closed this as completed in 6c0b803 Dec 29, 2022
@swsnr
Copy link
Author

swsnr commented Dec 29, 2022

🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant