Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: lazy.util.open hardcodes xdg-open #248

Closed
3 tasks done
swsnr opened this issue Dec 30, 2022 · 1 comment · Fixed by #251
Closed
3 tasks done

bug: lazy.util.open hardcodes xdg-open #248

swsnr opened this issue Dec 30, 2022 · 1 comment · Fixed by #251
Labels
bug Something isn't working

Comments

@swsnr
Copy link

swsnr commented Dec 30, 2022

Did you check docs and existing issues?

  • I have read all the lazy docs
  • I have searched the existing issues of lazy
  • I have searched the exsiting issues of the plugin I have a problem with

Neovim version (nvim -v)

0.8.1

Operating system/version

Linux

Describe the bug

lazy.util.open hard codes xdg-open, so K fails if xdg-open isn't present.

Naively, I'd have expected lazy to honour g:netrw_browsex_viewer, and was surprised to see that it doesn't. I checked the code to learn how to configure it, and saw that xdg-open was hardcoded.

Steps To Reproduce

  1. Uninstall xdg-open
  2. Press K anywhere in a Lazy window.

Expected Behavior

I'd have expected lazy to honour netrw or check g:netrw_browsex_viewer directly, or to provide an alternative option to change the command to open URLs.

Repro

No response

@swsnr swsnr added the bug Something isn't working label Dec 30, 2022
@folke folke closed this as completed in 679d85c Dec 30, 2022
@swsnr
Copy link
Author

swsnr commented Dec 30, 2022

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant