-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: autodetect non github urls #357
Comments
I understand, but for performance reasons I want to keep it simple. Custom url uses the Git supports a gazillion ways to specify a repo url, so there would always be cases not covered. |
How would it decrease performance? Lua pattern matching is extremely fast. |
It does add up I would want to support other correct git uris as well, but you;re right that for |
just for the record, the first thing I tried was https://gitlab.com/plug/repo.git, then then I looked at the manual. If any of the first had worked, I would've tried file:/// for sure had I needed a local plugin. |
Did you check the docs?
Is your feature request related to a problem? Please describe.
I added a sourcehut url and lazy tried to pull
https://github.com/https://git.sr.ht....
which made all my config fail.Describe the solution you'd like
If a
short plugin url
starts withhttps://
orgit@
- don't appendconfig.git.url_format
to it. It would be easier and more consistent then addingurl
key.Describe alternatives you've considered
Additional context
No response
The text was updated successfully, but these errors were encountered: