bug: wrong window offset when opening diff

[WilliamHsieh]

Did you check docs and existing issues?

• I have read all the lazy.nvim docs
• I have searched the existing issues of lazy.nvim
• I have searched the exsiting issues of plugins related to this issue

Neovim version (nvim -v)

0.8.2 Release

Operating system/version

wsl / macos

Describe the bug

After opening diff by pressing K on a commit, the top and bottom row of the diff buffer is showing messages from the previous layout.
Feel like it's a wrong offset when creating float command (both with border and without border).

without border

with border

Steps To Reproduce

1. nvim -u repro.lua
2. :Lazy
3. L to navigate to log panel
4. place the cursor on the commit from lazy 7260a2b
5. K

Expected Behavior

I think the top row is reserved for the title of lazy when the diff buffer is open on a certain line? However I found it distracting when reading diff.
I've tried to modify the margin

lazy.nvim/lua/lazy/util.lua

Line 15 in d211027

margin = { top = 3, left = 2, right = 2 },

, however, the behaviour seems to be different with and without borders. I can't quite figure out how to fix it.
Thank's for the great plugin nevertheless!

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

[folke]

That's actually intentional, so you normally still see the buttons of Lazy. I need to jump to the top before opening the diff though. Will fix

[WilliamHsieh]

Apart from this issue, I have some thoughts about the buttons and the idea of panes.
In my understanding, Install, Update, Sync, Clean, and Check are actions, when navigating to these panes and navigating back to Home, the UI isn't changing.
Unlike Profile, Debug, and Help which are different panes with different contexts.
My suggestion is that maybe we can group those action panes under the Home pane, only showing them when under Home panel, not only can it decouple the UI, and it's more intuitive to navigate.

What do you think about it? Would like to hear your thought :)

[folke]

true, but then we'd need to have two rows or something like that, which is also not ideal...

[WilliamHsieh]

true, but then we'd need to have two rows or something like that, which is also not ideal...

your right, will think about this more.

About the bug, the borderless works fine, however, there's an extra line at the bottom of the buffer with the border, is this intended?

[WilliamHsieh]

reminder ping @folke, the bug is still present with border (the bottom line)