-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: make config.defaults.version
overridable
#409
Comments
It is for version, but you have a point that we should ignore the default when any of the props you mentioned is set. Will fix! |
It's also already the case for commit and tag. Just not for branch |
Just noting here because it was a little confusing to figure out. I have I tried setting Solution was to set |
@jn64 You need to set I just clarified this in the docs as well |
Thanks, that makes more sense! |
fyi: setting something to These two tables are exactly the same in lua: Lua doesn't have the notion of |
Did you check the docs?
Is your feature request related to a problem? Please describe.
I assumed that
config.defaults.version = "*"
is overridable if plugin spec provides version/commit/branch/etc. But apparently, it is not.Describe the solution you'd like
Make
config.defaults.version
overridable if a plugin spec explicitly provides version/commit/branch/etc.Describe alternatives you've considered
At least explicitly mention this behavior in the docs.
Additional context
No response
The text was updated successfully, but these errors were encountered: